rondagostino commented on a change in pull request #10105:
URL: https://github.com/apache/kafka/pull/10105#discussion_r580575104
##########
File path: tests/kafkatest/services/performance/end_to_end_latency.py
##########
@@ -74,12 +74,15 @@ def __init__(self, context, num_nodes, kafka, topic,
num_records, compression_ty
def start_cmd(self, node):
args = self.args.copy()
args.update({
- 'zk_connect': self.kafka.zk_connect_setting(),
'bootstrap_servers':
self.kafka.bootstrap_servers(self.security_config.security_protocol),
'config_file': EndToEndLatencyService.CONFIG_FILE,
'kafka_run_class': self.path.script("kafka-run-class.sh", node),
'java_class_name': self.java_class_name()
})
+ if node.version < V_0_9_0_0:
Review comment:
> name it something like consumer_supports_bootstrap_server... bunch of
other bootstrap server functions
Good point. I renamed it `consumer_supports_bootstrap_server()` as you
suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
