chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r583381642
##########
File path: README.md
##########
@@ -167,7 +167,7 @@ Please note for this to work you should create/update user
maven settings (typic
### Installing the jars to the local Maven repository ###
- ./gradlewAll install
+ ./gradlewAll publishToMavenLocal
Review comment:
not sure whether this change is a kind of broken?
##########
File path: build.gradle
##########
@@ -1075,7 +1090,8 @@ project(':examples') {
archivesBaseName = "kafka-examples"
dependencies {
- compile project(':core')
+ implementation project(':clients')
Review comment:
Is this dependency redundant? The core module has `API` dependency from
clients module so clients module is already propagated to metadata module.
##########
File path: build.gradle
##########
@@ -2026,52 +2043,53 @@ project(':connect:runtime') {
archivesBaseName = "connect-runtime"
dependencies {
-
- compile project(':connect:api')
- compile project(':clients')
- compile project(':tools')
- compile project(':connect:json')
- compile project(':connect:transforms')
-
- compile libs.slf4jApi
- compile libs.jacksonJaxrsJsonProvider
- compile libs.jerseyContainerServlet
- compile libs.jerseyHk2
- compile libs.jaxbApi // Jersey dependency that was available in the JDK
before Java 9
- compile libs.activation // Jersey dependency that was available in the JDK
before Java 9
- compile libs.jettyServer
- compile libs.jettyServlet
- compile libs.jettyServlets
- compile libs.jettyClient
- compile(libs.reflections)
- compile(libs.mavenArtifact)
-
- testCompile project(':clients').sourceSets.test.output
- testCompile libs.easymock
- testCompile libs.junitJupiterApi
- testCompile libs.junitVintageEngine
- testCompile libs.powermockJunit4
- testCompile libs.powermockEasymock
- testCompile libs.mockitoCore
- testCompile libs.httpclient
-
- testCompile project(':clients').sourceSets.test.output
- testCompile project(':core')
- testCompile project(':core').sourceSets.test.output
-
- testRuntime libs.slf4jlog4j
+ implementation project(':connect:api')
Review comment:
I'm worry that connector projects which reference `connect:runtime`
module to include other connect modules (i.e `connect:api` and `connect:json`)
get broken by this change.
##########
File path: build.gradle
##########
@@ -219,34 +223,43 @@ subprojects {
options.compilerArgs << "--release" << minJavaVersion
}
- uploadArchives {
- repositories {
- signing {
- required { shouldSign }
- sign configurations.archives
-
- // To test locally, replace mavenUrl in ~/.gradle/gradle.properties
to file://localhost/tmp/myRepo/
- mavenDeployer {
- beforeDeployment { MavenDeployment deployment ->
signing.signPom(deployment) }
- repository(url: "${mavenUrl}") {
- authentication(userName: "${mavenUsername}", password:
"${mavenPassword}")
- }
- afterEvaluate {
- pom.artifactId = "${archivesBaseName}"
- pom.project {
- name 'Apache Kafka'
- packaging 'jar'
- url 'https://kafka.apache.org'
- licenses {
- license {
- name 'The Apache Software License, Version 2.0'
- url
'https://www.apache.org/licenses/LICENSE-2.0.txt'
- distribution 'repo'
- }
- }
- }
+ if (shouldPublish) {
+
+ publishing {
+ repositories {
+ // To test locally, replace mavenUrl in ~/.gradle/gradle.properties to
file://localhost/tmp/myRepo/
Review comment:
the `mavenUrl` is configurable (`-PmavenUrl=xxx`) so this comment is a
bit weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
