chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r583694082
##########
File path: build.gradle
##########
@@ -2026,52 +2043,53 @@ project(':connect:runtime') {
archivesBaseName = "connect-runtime"
dependencies {
-
- compile project(':connect:api')
- compile project(':clients')
- compile project(':tools')
- compile project(':connect:json')
- compile project(':connect:transforms')
-
- compile libs.slf4jApi
- compile libs.jacksonJaxrsJsonProvider
- compile libs.jerseyContainerServlet
- compile libs.jerseyHk2
- compile libs.jaxbApi // Jersey dependency that was available in the JDK
before Java 9
- compile libs.activation // Jersey dependency that was available in the JDK
before Java 9
- compile libs.jettyServer
- compile libs.jettyServlet
- compile libs.jettyServlets
- compile libs.jettyClient
- compile(libs.reflections)
- compile(libs.mavenArtifact)
-
- testCompile project(':clients').sourceSets.test.output
- testCompile libs.easymock
- testCompile libs.junitJupiterApi
- testCompile libs.junitVintageEngine
- testCompile libs.powermockJunit4
- testCompile libs.powermockEasymock
- testCompile libs.mockitoCore
- testCompile libs.httpclient
-
- testCompile project(':clients').sourceSets.test.output
- testCompile project(':core')
- testCompile project(':core').sourceSets.test.output
-
- testRuntime libs.slf4jlog4j
+ implementation project(':connect:api')
Review comment:
ya, I agree that referencing connect-runtime in compile time is weird.
However, core module is allowed to propagate client module. It would be better
to get consistent rule for both connect-runtime and core.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
