chia7712 commented on a change in pull request #10141: URL: https://github.com/apache/kafka/pull/10141#discussion_r584616679
########## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ########## @@ -812,6 +812,26 @@ object ReassignPartitionsCommand extends Logging { proposedAssignments } + private def describeTopics(adminClient: Admin, + topics: Set[String]) + : Map[String, TopicDescription] = { + adminClient.describeTopics(topics.asJava).values.asScala.map { + case (topicName, topicDescriptionFuture) => + try { + topicName -> topicDescriptionFuture.get + } + catch { + case t: ExecutionException if t.getCause != null => Review comment: How about using `classOf[UnknownTopicOrPartitionException].isInstance(t.getCause)`? That includes null check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org