ijuma commented on a change in pull request #10141:
URL: https://github.com/apache/kafka/pull/10141#discussion_r589424932
##########
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##########
@@ -812,6 +812,26 @@ object ReassignPartitionsCommand extends Logging {
proposedAssignments
}
+ private def describeTopics(adminClient: Admin,
+ topics: Set[String])
+ : Map[String, TopicDescription] = {
+ adminClient.describeTopics(topics.asJava).values.asScala.map {
+ case (topicName, topicDescriptionFuture) =>
+ try {
+ topicName -> topicDescriptionFuture.get
+ }
+ catch {
+ case t: ExecutionException =>
+ if
(classOf[UnknownTopicOrPartitionException].isInstance(t.getCause)) {
Review comment:
Hmm, I think this is an example of code that is less readable. If
`cause` may be nullable, it's better to write code that makes that clear rather
than a non obvious alternative that could have been used for many other reasons
(using `Option` to handle nullables is fine as a counter example since it's
common usage to do that).
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
