chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r585246882
##########
File path: build.gradle
##########
@@ -1586,15 +1605,17 @@ project(':streams:test-utils') {
archivesBaseName = "kafka-streams-test-utils"
dependencies {
- compile project(':streams')
- compile project(':clients')
+ implementation project(':streams')
Review comment:
I guess this is similar to `connect-runtime` that it is easy to be used
in users' testing scope. Maybe we should keep exposing both modules.
##########
File path: release.py
##########
@@ -631,7 +631,7 @@ def select_gpg_key():
contents = f.read()
if not user_ok("Going to build and upload mvn artifacts based on these
settings:\n" + contents + '\nOK (y/n)?: '):
fail("Retry again later")
-cmd("Building and uploading archives", "./gradlewAll uploadArchives",
cwd=kafka_dir, env=jdk8_env, shell=True)
+cmd("Building and uploading archives", "./gradlewAll publish", cwd=kafka_dir,
env=jdk8_env, shell=True)
Review comment:
the root/`README.md` still use `./gradlewAll uploadArchives`. It would
be great to make them consistent.
##########
File path: build.gradle
##########
@@ -1468,7 +1461,7 @@ project(':streams') {
include('log4j*jar')
include('*hamcrest*')
}
- from (configurations.runtime) {
+ from (configurations.runtimeClasspath) {
Review comment:
Is there a jira already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
