ijuma commented on pull request #10203: URL: https://github.com/apache/kafka/pull/10203#issuecomment-789798301
Thanks for testing @rhauch! > @ijuma, I ran `./gradlew clean install releaseTarGz -x signArchives` (which is still in the README) and it failed with: The readme was wrong when it comes to this since signing was only triggered when `uploadArchives` was called. I updated the readme instead of making code changes. > These do not appear to publish source, test or test source JARs to the local Maven repository, unlike ./gradlewAll install on the 2.8 branch. Good catch, I updated the build so that this works with the new plugin. > Is it intentional to no longer publish .asc files to the local Maven repository? I do see with this PR the install commands now publish .module files that contain the various hashes, but I don't know if that's expected. It seems like the new plugin only includes those when `publish` is called instead of `publishToMavenLocal`. That seems fine, I don't see any reason why those files are useful when installing to the local repo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
