hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586646515



##########
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##########
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId: Int,
     if (partition.isReplicaFor(brokerId)) {
       _localChanged.add(partition)
     } else if (prevPartition != null && prevPartition.isReplicaFor(brokerId)) {

Review comment:
       Yes, it is possible. In this case, we should not remove the local state, 
so it does not get added to `_localRemoved`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to