ijuma commented on a change in pull request #10252: URL: https://github.com/apache/kafka/pull/10252#discussion_r587128413
########## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ########## @@ -483,7 +475,7 @@ private ApiError createTopic(CreatableTopic topic, " times: " + e.getMessage()); } } - Uuid topicId = new Uuid(random.nextLong(), random.nextLong()); + Uuid topicId = Uuid.randomUuid(); Review comment: Note that we have switched from a regular `Random` to a `SecureRandom`. Probably a good idea, but it could have perf implications. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org