[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

[GitBox]

mjsax commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r586863239



##########
File path: build.gradle
##########
@@ -974,8 +974,8 @@ project(':core') {
     from(project(':streams:streams-scala').configurations.runtime) { 
into("libs/") }
     from(project(':streams:test-utils').jar) { into("libs/") }
     from(project(':streams:test-utils').configurations.runtime) { 
into("libs/") }
-    from(project(':streams:examples').jar) { into("libs/") }
-    from(project(':streams:examples').configurations.runtime) { into("libs/") }
+    from(project(':streams-examples').jar) { into("libs/") }
+    from(project(':streams-examples').configurations.runtime) { into("libs/") }

Review comment:
       As describe on the Jira, the goal is to get rid of the dependency of 
`stream` model on `connect` module. It's ok for `streams-examples` to depend on 
it, but for `streams` is cleaner to not have it, and it's only there to pull in 
stuff for the examples.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org