mjsax commented on a change in pull request #10300:
URL: https://github.com/apache/kafka/pull/10300#discussion_r592036244
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java
##########
@@ -37,7 +37,6 @@
public class ProcessorNode<KIn, VIn, KOut, VOut> {
- // TODO: 'children' can be removed when #forward() via index is removed
Review comment:
`children` is actually used again in the meantime and we should keep it.
(It's of course somewhat redundant to `childByName` but is also preserves
the order of the nodes -- using a `TreeMap` might work however, as we return a
`List` of child name form one method it would imply extra work to extract the
keys...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
