ableegoldman commented on a change in pull request #10300:
URL: https://github.com/apache/kafka/pull/10300#discussion_r593553762
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContextTest.java
##########
@@ -155,29 +155,20 @@ public void shouldReturnEmptyHeadersIfHeadersAreNotSet() {
assertThat(context.headers(), is(emptyIterable()));
}
- @Test
- public void shouldThrowIllegalStateExceptionOnHeadersIfNoRecordContext() {
Review comment:
Just want to make sure I understand the background here: as of KIP-478
we no longer throw if there's no active RecordContext, but instead just return
empty. Is that right? If so then yes, an updated test like
`shouldReturnEmptyHeaderIfRecordContextIsNull` seems good to have
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
