hachikuji commented on a change in pull request #10289:
URL: https://github.com/apache/kafka/pull/10289#discussion_r592853088
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -939,12 +951,27 @@ private FetchResponseData buildEmptyFetchResponse(
);
}
- private boolean hasValidClusterId(FetchRequestData request) {
+ private boolean hasValidClusterId(ApiMessage request) {
Review comment:
What should we do if we see this error in a response? It looks like it
would hit `handleUnexpectedError` currently which just logs an error. That
might be ok for now. I think there is a window during startup when we could
consider these errors to be fatal. This would be helpful detecting
configuration problems. We probably do not want them to be fatal in all cases
though because that might result in a misconfigured node killing a stable
cluster.
##########
File path: clients/src/main/resources/common/message/VoteRequest.json
##########
@@ -21,7 +21,7 @@
"validVersions": "0",
"flexibleVersions": "0+",
"fields": [
- { "name": "ClusterId", "type": "string", "versions": "0+",
+ { "name": "ClusterId", "type": "string", "versions": "0+", "ignorable":
true,
Review comment:
Why do we need this to be ignorable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
