dengziming commented on a change in pull request #10289:
URL: https://github.com/apache/kafka/pull/10289#discussion_r597453270
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -814,6 +822,10 @@ private EndQuorumEpochResponseData
handleEndQuorumEpochRequest(
) throws IOException {
EndQuorumEpochRequestData request = (EndQuorumEpochRequestData)
requestMetadata.data;
+ if (!hasValidClusterId(request)) {
Review comment:
I tried this approach, it seems that voter and leader is partition level
terminology so that `validateVoterOnlyRequest` is used to get a partition level
error but cluster validate is a request level error, we'd better separate these
2 errors since we are making way for multi-raft. I think we can add a
`validateRequest` method to get request level error, WDYT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
