vvcephei commented on a change in pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#discussion_r601785655
##########
File path:
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java
##########
@@ -113,6 +114,9 @@ public MockClient kafkaClient() {
@Override
public void close() {
+ // tell the admin client to close now
+ this.adminClient.close(Duration.ZERO);
+ // block until it is really closed
this.adminClient.close();
Review comment:
I considered it, but at the same time, it seemed nice to actually wait
until the admin client's thread exits, so we don't get too many threads stacked
up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
