ijuma commented on a change in pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#discussion_r602916225
##########
File path:
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java
##########
@@ -113,6 +114,9 @@ public MockClient kafkaClient() {
@Override
public void close() {
+ // tell the admin client to close now
+ this.adminClient.close(Duration.ZERO);
+ // block until it is really closed
this.adminClient.close();
Review comment:
What if that never happens? It's better to always have a timeout in
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
