[GitHub] [kafka] ableegoldman commented on a change in pull request #10407: KAFKA-12523: handle TaskCorruption for revoked tasks & remove commit in handleCorruption

[GitBox]

ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602528819



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -611,6 +607,9 @@ boolean runLoop() {
                 if (processingMode == ProcessingMode.EXACTLY_ONCE_ALPHA || 
processingMode == ProcessingMode.EXACTLY_ONCE_BETA) {
                     return false;
                 }
+                // TODO: extract this catch block to encompass all of runLoop, 
in case exceptions slip through one of the

Review comment:
       Ah, gotcha. Maybe you can tack this onto your PR if you think it makes 
sense, otherwise I can file a quick ticket to follow up on it 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org