[GitHub] [kafka] ableegoldman commented on a change in pull request #10407: KAFKA-12523: handle TaskCorruption for revoked tasks & remove commit in handleCorruption

[GitBox]

ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602587542



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -611,6 +607,9 @@ boolean runLoop() {
                 if (processingMode == ProcessingMode.EXACTLY_ONCE_ALPHA || 
processingMode == ProcessingMode.EXACTLY_ONCE_BETA) {
                     return false;
                 }
+                // TODO: extract this catch block to encompass all of runLoop, 
in case exceptions slip through one of the

Review comment:
       If we don't extract it then anything thrown in any of these catch blocks 
(eg from `handleCorruption`) will miss the exception handler, not be recorded 
in the failed thread sensor, etc. I ended up just opening a quick hotfix PR so 
we can get this into any ongoing releases that need it without coupling it to 
anything else we have going on right now: 
https://github.com/apache/kafka/pull/10417




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org