jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r605143191
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -775,9 +776,10 @@ class LogManager(logDirs: Seq[File],
* @param topicPartition The partition whose log needs to be returned or
created
* @param isNew Whether the replica should have existed on the broker or not
* @param isFuture True if the future log of the specified partition should
be returned or created
+ * @param topicId The topic ID of the topic used in the case of log creation.
* @throws KafkaStorageException if isNew=false, log is not found in the
cache and there is offline log directory on the broker
*/
- def getOrCreateLog(topicPartition: TopicPartition, isNew: Boolean = false,
isFuture: Boolean = false): Log = {
+ def getOrCreateLog(topicPartition: TopicPartition, isNew: Boolean = false,
isFuture: Boolean = false, topicId: Option[Uuid]): Log = {
Review comment:
If not, throw an error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
