jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r605144053
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -262,6 +266,7 @@ class Log(@volatile private var _dir: File,
val producerStateManager: ProducerStateManager,
logDirFailureChannel: LogDirFailureChannel,
private val hadCleanShutdown: Boolean = true,
+ @volatile var topicId: Option[Uuid],
val keepPartitionMetadataFile: Boolean = true) extends Logging with
KafkaMetricsGroup {
Review comment:
I'm wondering about the ZK controller case here. Before we had
Uuid.ZERO_UUID represent an unset ID, but I thought it was too easy to use
thinking it was a valid ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
