jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r605167349
##########
File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java
##########
@@ -60,19 +61,21 @@
@Override
void close();
- class Batch<T> {
+ final class Batch<T> implements Iterable<T> {
Review comment:
@hachikuji given that we use this type in `SnapshotReader<T>` I am okay
moving this type to something like `o.a.k.r.Batch` instead of
`o.a.k.r.BatchReader.Batch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
