jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r610939450
##########
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/MetaLogRaftShim.java
##########
@@ -124,6 +125,11 @@ public void handleCommit(BatchReader<ApiMessageAndVersion>
reader) {
}
}
+ @Override
+ public void handleSnapshot(SnapshotReader<ApiMessageAndVersion>
reader) {
+ reader.close();
Review comment:
In the future yes. Simply ignore the snapshot is okay for now for the
following reasons:
1. We are getting rid of this shim in
https://github.com/apache/kafka/pull/10497
2. None of the kraft listeners generate snapshots so this should never be
called
3. We will implement snapshot loading for the controller and broker as part
of this jira: https://issues.apache.org/jira/browse/KAFKA-12466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
