[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

[GitBox]

ccding commented on a change in pull request #10405:
URL: https://github.com/apache/kafka/pull/10405#discussion_r605901016



##########
File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java
##########
@@ -427,7 +445,7 @@ public static FileRecords open(File file,
                                    boolean preallocate) throws IOException {
         FileChannel channel = openChannel(file, mutable, fileAlreadyExists, 
initFileSize, preallocate);
         int end = (!fileAlreadyExists && preallocate) ? 0 : Integer.MAX_VALUE;
-        return new FileRecords(file, channel, 0, end, false);
+        return new FileRecords(file, channel, 0, end, false, mutable && 
!fileAlreadyExists);

Review comment:
       fixed with passing in the `hadCleanShutdown` flag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org