ccding commented on a change in pull request #10405:
URL: https://github.com/apache/kafka/pull/10405#discussion_r606039773
##########
File path: core/src/main/scala/kafka/log/LogSegment.scala
##########
@@ -95,6 +97,9 @@ class LogSegment private[log] (val log: FileRecords,
/* the number of bytes since we last added an entry in the offset index */
private var bytesSinceLastIndexEntry = 0
+ /* whether or not we need to flush the parent dir during flush */
Review comment:
Not really. We changed the value of `atomicNeedsFlushParentDir` after
the first flush. The value of `needsFlushParentDir` in the construction
function is for during the first flush. Do you have any suggestions on how to
comment on them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
