showuon commented on a change in pull request #10457:
URL: https://github.com/apache/kafka/pull/10457#discussion_r606161628
##########
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -98,15 +100,15 @@ class TopicCommandWithAdminClientTest extends
KafkaServerTestHarness with Loggin
@Test
def testCreate(): Unit = {
createAndWaitTopic(new TopicCommandOptions(
- Array("--partitions", "2", "--replication-factor", "1", "--topic",
testTopicName)))
+ brokerOptions ++ Array("--partitions", "2", "--replication-factor", "1",
"--topic", testTopicName)))
Review comment:
We didn't `checkArgs` before, so it's ok to not pass the
`--bootstrap-server` option. Since we make it as required argument now, we need
to pass the option explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
