showuon commented on a change in pull request #10457:
URL: https://github.com/apache/kafka/pull/10457#discussion_r606535769



##########
File path: 
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -65,9 +65,10 @@ class TopicCommandWithAdminClientTest extends 
KafkaServerTestHarness with Loggin
   private val numPartitions = 1

Review comment:
       @ijuma , we already have a `TopicCommandTest` to do Unit test. This 
`TopicCommandWithAdminClientTest` is much like an integration test. How about 
rename to `TopicCommandIntegrationTest` just like 
`DeleteOffsetsConsumerGroupCommandIntegrationTest` in the same folder?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to