[ 
https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315140#comment-17315140
 ] 

A. Sophie Blee-Goldman commented on KAFKA-12492:
------------------------------------------------

The kafka-site repo is what the actual, live docs are built from. That's why 
there are separate folders like 27, 26, etc -- these correspond to the docs for 
versions 2.7 and 2.6, and so on. You only need to submit a PR to the kafka-site 
repo if you want your change to show up immediately -- if you don't mind 
waiting for the next release, you can just open a PR to fix the docs in the 
kafka repo directly. Then, these will be copied over to the kafka-site repo and 
made live when the next version is released.

Obviously it would be ideal if we could fix this in all versions, but it's 
probably sufficient to just fix it going forward. The 2.8 release is actually 
going on at the moment, so I would recommend submitting a PR to the kafka repo 
for now. If we can get it merged before 2.8 is released, then we're good -- 
otherwise you can open a followup PR with the same fix in just the 28 
subdirectory of the kafka-site repo.

I'm not sure why you're getting a 403, I was able to setup a local apache 
server to test some docs but that was a while ago. Since it's just a fix of an 
existing formatting error, I wouldn't worry about testing it too much. As long 
as you can figure out why the formatting was messed up to begin with, and feel 
reasonably confident in your fix, then that's good enough. Remember, once the 
fix is in kafka-site it'll be live so you can just see what it looks like then. 
If something is still off, you can always submit a followup PR to fix it right 
away in kafka-site

> Formatting of example RocksDBConfigSetter is messed up
> ------------------------------------------------------
>
>                 Key: KAFKA-12492
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12492
>             Project: Kafka
>          Issue Type: Bug
>          Components: documentation, streams
>            Reporter: A. Sophie Blee-Goldman
>            Assignee: Ben Chen
>            Priority: Trivial
>              Labels: docs, newbie
>
> See the example implementation class CustomRocksDBConfig in the docs for the 
> rocksdb.config.setter
> https://kafka.apache.org/documentation/streams/developer-guide/config-streams.html#rocksdb-config-setter



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to