[ 
https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315183#comment-17315183
 ] 

A. Sophie Blee-Goldman commented on KAFKA-12492:
------------------------------------------------

Thanks, I'll take a look. But note that you always need to submit a docs PR 
against the kafka-repo, while the kafka-site repo is optional. The reason being 
what I said above, ie during a release the docs from kafka get copied over to 
kafka-site. So if you only fix them in kafka-site but not in kafka, the fix 
will just get wiped out when the next release comes up. 

In general we usually do the kafka PR before the kafka-site PR, for that reason 
among others. But that's not a hard rule or anything -- my point is just that 
you need a PR for the kafka repo as well. 

> Formatting of example RocksDBConfigSetter is messed up
> ------------------------------------------------------
>
>                 Key: KAFKA-12492
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12492
>             Project: Kafka
>          Issue Type: Bug
>          Components: documentation, streams
>            Reporter: A. Sophie Blee-Goldman
>            Assignee: Ben Chen
>            Priority: Trivial
>              Labels: docs, newbie
>
> See the example implementation class CustomRocksDBConfig in the docs for the 
> rocksdb.config.setter
> https://kafka.apache.org/documentation/streams/developer-guide/config-streams.html#rocksdb-config-setter



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to