ableegoldman commented on a change in pull request #10512:
URL: https://github.com/apache/kafka/pull/10512#discussion_r610943138



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java
##########
@@ -254,4 +258,41 @@ public static RebalanceProtocol forId(byte id) {
         }
     }
 
+    /**
+     * Get a list of configured instances of {@link 
org.apache.kafka.clients.consumer.ConsumerPartitionAssignor}
+     * based on the class names/types specified by {@link 
org.apache.kafka.clients.consumer.ConsumerConfig#PARTITION_ASSIGNMENT_STRATEGY_CONFIG}
+     */
+    public static List<ConsumerPartitionAssignor> 
getAssignorInstances(List<String> assignorClasses, Map<String, Object> configs) 
{

Review comment:
       nit: this should be package private I think




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to