jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r610995124
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -355,24 +373,29 @@ private void fireHandleResign(int epoch) {
}
@Override
- public void initialize() throws IOException {
- quorum.initialize(new OffsetAndEpoch(log.endOffset().offset,
log.lastFetchedEpoch()));
+ public void initialize() {
+ try {
+ quorum.initialize(new OffsetAndEpoch(log.endOffset().offset,
log.lastFetchedEpoch()));
- long currentTimeMs = time.milliseconds();
- if (quorum.isLeader()) {
- throw new IllegalStateException("Voter cannot initialize as a
Leader");
- } else if (quorum.isCandidate()) {
- onBecomeCandidate(currentTimeMs);
- } else if (quorum.isFollower()) {
- onBecomeFollower(currentTimeMs);
- }
+ long currentTimeMs = time.milliseconds();
+ if (quorum.isLeader()) {
+ throw new IllegalStateException("Voter cannot initialize as a
Leader");
+ } else if (quorum.isCandidate()) {
+ onBecomeCandidate(currentTimeMs);
+ } else if (quorum.isFollower()) {
+ onBecomeFollower(currentTimeMs);
+ }
- // When there is only a single voter, become candidate immediately
- if (quorum.isVoter()
- && quorum.remoteVoters().isEmpty()
- && !quorum.isLeader()
- && !quorum.isCandidate()) {
- transitionToCandidate(currentTimeMs);
+ // When there is only a single voter, become candidate immediately
+ if (quorum.isVoter()
+ && quorum.remoteVoters().isEmpty()
+ && !quorum.isLeader()
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
