kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r615186466
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java
##########
@@ -129,4 +133,32 @@ public void testLoadingMixOfValidAndInvalidPlugins()
throws Exception {
assertNotNull(classLoader.pluginClassLoader(pluginClassName));
}
}
+
+ @Test
+ public void testAddMultiplePluginsWithSameClass() {
Review comment:
I felt the same but I wanted to see the log statement and there was no
way to see it so I added the test, the only other option was to add a
ConflictListener but that seemed like a hammer to kill a mosquito :).
let me see if on Monday I can do a test by probing the getPluginLoader
method to ensure that the highest version plugin is returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
