kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r615186346
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##########
@@ -187,17 +192,24 @@ private static PluginClassLoader newPluginClassLoader(
);
}
- private <T> void addPlugins(Collection<PluginDesc<T>> plugins, ClassLoader
loader) {
+ //visible for testing
+ <T> void addPlugins(Collection<PluginDesc<T>> plugins, ClassLoader loader)
{
for (PluginDesc<T> plugin : plugins) {
String pluginClassName = plugin.className();
SortedMap<PluginDesc<?>, ClassLoader> inner =
pluginLoaders.get(pluginClassName);
+ boolean pluginConflict = false;
if (inner == null) {
inner = new TreeMap<>();
pluginLoaders.put(pluginClassName, inner);
// TODO: once versioning is enabled this line should be moved
outside this if branch
log.info("Added plugin '{}'", pluginClassName);
+ } else {
+ pluginConflict = true;
}
inner.put(plugin, loader);
+ if (pluginConflict) {
+ log.error("Detected multiple copies of plugin '{}', one of
these will be used '{}'", pluginClassName, inner.keySet());
+ }
Review comment:
we can't move in else because we need to report all versions(see
`inner.keySet` in the `log.error`) and they are added outside the if/else
block. Also, I cant use size() check because sometimes the same plugin with the
same version exists in 2 places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
