mumrah commented on a change in pull request #10561:
URL: https://github.com/apache/kafka/pull/10561#discussion_r616723660
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,
isrState = proposedIsrState
if (!alterIsrManager.submit(alterIsrItem)) {
- // If the ISR manager did not accept our update, we need to revert back
to previous state
+ // If the ISR manager did not accept our update, we need to revert back
to previous state.
Review comment:
How about
> If the ISR manager did not accept our update, we need to revert the
proposed state.
I'm not quite sure what you mean by ZK-specific. When I say "ISR state was
updated", I really mean "when Partition#isrState was updated". How about:
> This can happen if the Partition's ISR state is changed due to handling a
LeaderAndIsrRequest from the controller
> while an AlterIsrRequest is still in-flight. See KAFKA-12686 for details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
