cmccabe commented on a change in pull request #10561:
URL: https://github.com/apache/kafka/pull/10561#discussion_r617078726
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,
isrState = proposedIsrState
if (!alterIsrManager.submit(alterIsrItem)) {
- // If the ISR manager did not accept our update, we need to revert back
to previous state
+ // If the ISR manager did not accept our update, we need to revert back
to previous state.
Review comment:
KRaft controllers do not make LeaderAndIsr requests. So the description
here is specific to the ZK-based controller. I was suggesting that we either
make this more generic or talk about both the old and new ways of updating the
state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
