[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

[GitBox]

spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616758960



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##########
@@ -60,20 +83,44 @@
     }
 
     private class KStreamKStreamJoinProcessor extends AbstractProcessor<K, V1> 
{
+        private final Predicate<Windowed<KeyAndJoinSide<K>>> 
recordWindowHasClosed =

Review comment:
       Done

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##########
@@ -60,20 +83,44 @@
     }
 
     private class KStreamKStreamJoinProcessor extends AbstractProcessor<K, V1> 
{
+        private final Predicate<Windowed<KeyAndJoinSide<K>>> 
recordWindowHasClosed =
+            windowedKey -> windowedKey.window().start() + joinAfterMs + 
joinGraceMs < maxObservedStreamTime.get();
 
         private WindowStore<K, V2> otherWindow;
         private StreamsMetricsImpl metrics;
         private Sensor droppedRecordsSensor;
+        private Optional<WindowStore<KeyAndJoinSide<K>, LeftOrRightValue>> 
outerJoinWindowStore = Optional.empty();
 
         @SuppressWarnings("unchecked")
         @Override
         public void init(final ProcessorContext context) {
             super.init(context);
             metrics = (StreamsMetricsImpl) context.metrics();
             droppedRecordsSensor = 
droppedRecordsSensorOrSkippedRecordsSensor(Thread.currentThread().getName(), 
context.taskId().toString(), metrics);
-            otherWindow = (WindowStore<K, V2>) 
context.getStateStore(otherWindowName);
+            otherWindow = context.getStateStore(otherWindowName);

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org