spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616762075
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##########
@@ -118,20 +142,47 @@
final ProcessorGraphNode<K1, V2> otherWindowedStreamsNode = new
ProcessorGraphNode<>(otherWindowStreamProcessorName,
otherWindowStreamProcessorParams);
builder.addGraphNode(otherGraphNode, otherWindowedStreamsNode);
+ Optional<StoreBuilder<WindowStore<KeyAndJoinSide<K1>,
LeftOrRightValue<V1, V2>>>> outerJoinWindowStore = Optional.empty();
+ if (leftOuter || rightOuter) {
Review comment:
I did not find how to get the configs from KStreamImplJoin. I tracked
the configs being passed from the StreamTask down to the processor when
processing the record, so I ended up checking the flag at that point. I could
refactor the code to pass the configs when constructing the joins, but that
require more changes in different places which I'm not sure if it will make
things incompatible. Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
