ijuma commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r619888968
##########
File path: build.gradle
##########
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
- from (configurations.testRuntime) {
- include('slf4j-log4j12*')
- include('log4j*jar')
- include('*hamcrest*')
+ from (configurations.testCompileClasspath) {
+ include('jackson*')
+ include('slf4j-api*')
}
from (configurations.runtimeClasspath) {
- exclude('kafka-clients*')
+ include('connect*')
+ include('*java*')
+ include('*jni*')
Review comment:
Why did we switch from exclude to include?
##########
File path: build.gradle
##########
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
- from (configurations.testRuntime) {
Review comment:
@vvcephei do you know why we're copying test dependencies here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
