[GitHub] [kafka] dejan2609 commented on a change in pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

[GitBox]

dejan2609 commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r620558374



##########
File path: build.gradle
##########
@@ -1491,13 +1491,14 @@ project(':streams') {
   }
 
   tasks.create(name: "copyDependantLibs", type: Copy) {
-    from (configurations.testRuntime) {
-      include('slf4j-log4j12*')
-      include('log4j*jar')
-      include('*hamcrest*')
+    from (configurations.testCompileClasspath) {
+      include('jackson*')
+      include('slf4j-api*')
     }
     from (configurations.runtimeClasspath) {
-      exclude('kafka-clients*')
+      include('connect*')
+      include('*java*')
+      include('*jni*')

Review comment:
       Nice catch @ijuma ! Thing is that my intention was to put forward some 
solution that just **_works_** (in a same way that previous, see attached 
snapshots below). 
   
   So, I moved around **_java_** and **_java-library_** plugins configurations 
and after scrapping something I just left solution as-is... of course, 
**_exclude_** declaration is an optimal solution (because it handles 
dependencies that will be included into related configuration in the future).
   
   All-in-all: reverting back to an **_'exclude'_** directive.
   
   ![2021-04-26 19_23_24-kafka – build gradle 
(kafka)](https://user-images.githubusercontent.com/19467899/116132569-fee72600-a6cd-11eb-8fa6-c52ec1e2435f.png)
   ![2021-04-26 19_12_06-kafka – build gradle 
(kafka)](https://user-images.githubusercontent.com/19467899/116132571-ff7fbc80-a6cd-11eb-9e7c-332cfc776a4f.png)
   
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org