rondagostino commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-830858518


   @cmccabe The code now auto-creates any ZooKeeper chroot in 
`KafkaZkClient.apply()`.  I added a unit test for it in KafkaZkClientTest, 
which passes, and it also gets exercised in a few system tests that set a ZK 
chroot path (`delegation_token_test.py` is one such file, and it passed locally 
for me with this change).  `KafkaRaftServer` no longer has any reference to 
ZooKeeper.
   
   Assuming the above change is acceptable, I think the remaining issue from 
your initial review is the issue of forwarding.  Take a look at my comment 
above and let me know what you think -- keep what I have, which short-circuits 
the forwarding, or forward to the controller and pass the ACL requests to the 
registered authorizer instance.  I suspect the latter is better, but let me 
know your opinion since you suggested this could be done in a follow-on PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to