cmccabe commented on a change in pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#discussion_r630603137
##########
File path: core/src/main/scala/kafka/server/MetadataSupport.scala
##########
@@ -91,28 +93,42 @@ case class ZkSupport(adminManager: ZkAdminManager,
override def controllerId: Option[Int] = metadataCache.getControllerId
}
-case class RaftSupport(fwdMgr: ForwardingManager, metadataCache:
RaftMetadataCache, quotaCache: ClientQuotaCache)
+case class RaftSupport(fwdMgr: ForwardingManager, metadataCache:
RaftMetadataCache, quotaCache: ClientQuotaCache, config: KafkaConfig)
extends MetadataSupport {
+ if (config.requiresZookeeper) {
+ throw new IllegalStateException("Config specifies ZooKeeper but metadata
support instance is for Raft")
+ }
override val forwardingManager: Option[ForwardingManager] = Some(fwdMgr)
override def requireZkOrThrow(createException: => Exception): ZkSupport =
throw createException
- override def requireRaftOrThrow(createException: => Exception): RaftSupport
= this
-
- override def ensureConsistentWith(config: KafkaConfig): Unit = {
- if (config.requiresZookeeper) {
- throw new IllegalStateException("Config specifies ZooKeeper but metadata
support instance is for Raft")
+ override def requireZkAuthorizerOrThrow(createException: => Exception) = {
Review comment:
I don't think we need (or want) to special-case the ZK authorizer here.
There is a Confluent authorizer that doesn't depend on ZK, and also a Cloudera
one. We don't want to break them. Just forward everything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
