cmccabe commented on a change in pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#discussion_r633749112
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -99,6 +100,9 @@ class ControllerApis(val requestChannel: RequestChannel,
case ApiKeys.SASL_HANDSHAKE => handleSaslHandshakeRequest(request)
case ApiKeys.SASL_AUTHENTICATE =>
handleSaslAuthenticateRequest(request)
case ApiKeys.CREATE_PARTITIONS => handleCreatePartitions(request)
+ case ApiKeys.DESCRIBE_ACLS => aclApis.handleDescribeAcls(request)
Review comment:
We might want the controller to process DescribeAcls for debug purposes.
There's no reason to artificially disable it from processing the RPC, although
I agree that it will normally not be used.
##########
File path: clients/src/main/resources/common/message/DeleteAclsRequest.json
##########
@@ -16,7 +16,7 @@
{
"apiKey": 31,
"type": "request",
- "listeners": ["zkBroker"],
+ "listeners": ["zkBroker", "broker", "controller"],
Review comment:
(See above comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
