wcarlson5 commented on a change in pull request #10676:
URL: https://github.com/apache/kafka/pull/10676#discussion_r631951243
##########
File path: streams/src/test/java/org/apache/kafka/streams/TopologyTest.java
##########
@@ -427,8 +428,8 @@ public void singleSourceShouldHaveSingleSubtopology() {
final TopologyDescription.Source expectedSourceNode =
addSource("source", "topic");
expectedDescription.addSubtopology(
- new InternalTopologyBuilder.Subtopology(0,
- Collections.singleton(expectedSourceNode)));
+ new SubtopologyDescription(0,
+
Collections.singleton(expectedSourceNode)));
Review comment:
nit: are these indents right?
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -59,10 +58,6 @@ public TaskId(final int topicGroupId, final int partition,
final String namedTop
}
}
- public Optional<String> namedTopology() {
Review comment:
If we don't have this could we add something like it to `TaskMetadata`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
