ableegoldman commented on a change in pull request #10676:
URL: https://github.com/apache/kafka/pull/10676#discussion_r632010573
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -59,10 +58,6 @@ public TaskId(final int topicGroupId, final int partition,
final String namedTop
}
}
- public Optional<String> namedTopology() {
Review comment:
Hm, `TaskMetadata` is also a public class, right? I think we'll need to
do something similar in that case, ie add an internal `NamedTaskMetadata` class
that exposes the `namedTopology` and then you can access it via something like
`NamedTaskMetadata.extractNamedTopology(TaskMetadata)`
It's unfortunate that `TaskMetadata` has the `taskId` field as a String,
rather than as an actual `TaskId` object -- not sure what the motivation there
was 😕 I might try to do a very small KIP to fix that, and then we won't have
to bother with this at all (you can just use the internal `NamedTaskId`
class/method to access the `namedTopology`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
