jsancio commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r633956837



##########
File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java
##########
@@ -57,4 +60,9 @@
      */
     @Override
     void close();
+
+    static <T> BatchReader<T> singleton(Batch<T> batch) {

Review comment:
       I removed this method. I think it is a dangerous method to have in 
`BatchReader` since batch readers created this way do not integrate with the 
rest of the `KafkaRaftClient`. This method was only used for tests so I just 
modified those cases to use `MemoryBatchReader` directly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to