[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

cmccabe commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r635613572



##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -2261,6 +2260,11 @@ private Long append(int epoch, List<T> records, boolean 
isAtomic) {
         return shutdownComplete;
     }
 
+    @Override
+    public void resign(int epoch) {
+        throw new UnsupportedOperationException();

Review comment:
       For some reason, I thought this was already implemented. But you're 
correct, it is not currently implemented. Maybe we should have this for 3.0, 
since controller bugs do happen sometimes...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org