kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645441207
##########
File path: core/src/main/scala/kafka/log/LogLoader.scala
##########
@@ -246,17 +262,17 @@ object LogLoader extends Logging {
return fn
} catch {
case e: LogSegmentOffsetOverflowException =>
- info(s"${params.logIdentifier}Caught segment overflow error:
${e.getMessage}. Split segment and retry.")
- Log.splitOverflowedSegment(
+ info(s"${params.logIdentifier} Caught segment overflow error:
${e.getMessage}. Split segment and retry.")
+ val result = Log.splitOverflowedSegment(
e.segment,
params.segments,
params.dir,
params.topicPartition,
params.config,
params.scheduler,
params.logDirFailureChannel,
- params.producerStateManager,
params.logIdentifier)
+ deleteProducerSnapshotsAsync(result.deletedSegments, params)
Review comment:
@junrao I thought about this again. Correct me if I'm wrong, but it
appears we may be altering existing behavior if we go down this route. Should
we do it in a separate PR to isolate the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
