kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r648133473
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1578,144 +1409,85 @@ class Log(@volatile private var _dir: File,
.map(_.messageOffset)
.getOrElse(maxOffsetInMessages - Integer.MAX_VALUE)
- roll(Some(rollOffset))
+ val newSegment = localLog.roll(Some(rollOffset))
+ afterRoll(newSegment)
+ newSegment
} else {
segment
}
}
/**
- * Roll the log over to a new active segment starting with the current
logEndOffset.
+ * Roll the local log over to a new active segment starting with the current
logEndOffset.
Review comment:
Done in 8ebb39f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
