mjsax commented on a change in pull request #10861:
URL: https://github.com/apache/kafka/pull/10861#discussion_r651362625
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
##########
@@ -76,18 +76,37 @@
private final long graceMs;
+ protected final boolean enableSpuriousResultFix;
+
+ protected JoinWindows(final JoinWindows joinWindows) {
Review comment:
Not really possible. Multiple issues:
- we still need a protected constructor in `JoinWindows`
- we need to make `graceMs` protected
- blocker: we need to make the _public_ members `beforeMs` and `afterMs`
non-final (and we cannot do this...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
