izzyacademy commented on a change in pull request #10861: URL: https://github.com/apache/kafka/pull/10861#discussion_r652088281
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ########## @@ -150,12 +150,11 @@ public long get() { // Time shared between joins to keep track of the maximum stream time final MaxObservedStreamTime maxObservedStreamTime = new MaxObservedStreamTime(); + final JoinWindowsInternal internalWindows = new JoinWindowsInternal(windows); final KStreamKStreamJoin<K1, R, V1, V2> joinThis = new KStreamKStreamJoin<>( true, otherWindowStore.name(), - windows.beforeMs, - windows.afterMs, - windows.gracePeriodMs(), + internalWindows, Review comment: I like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org