jolshan commented on a change in pull request #10754:
URL: https://github.com/apache/kafka/pull/10754#discussion_r652022729
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -337,6 +337,9 @@ class Log(@volatile private var _dir: File,
}
} else if (keepPartitionMetadataFile) {
_topicId.foreach(partitionMetadataFile.write)
+ } else {
Review comment:
Yeah. Unfortunately there is a lot going on here. I've edited the
comment and spacing to make it a little clearer. If we still think it needs
adjustment, I can try making a new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
